Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid importing dlib when it is not used #865

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Avoid importing dlib when it is not used #865

merged 2 commits into from
Dec 21, 2024

Conversation

roflcoopter
Copy link
Owner

Provies two changes:

  • Remove import of image_files_in_folder from face_recognition.face_recognition_cli to avoid importing dlib from other components
  • Lazyload all API handlers so they are only imported once they are used

Fixes: #837 (comment)

@netlify Netlify
Copy link

netlify bot commented Dec 21, 2024 •
edited
Loading

✅ Deploy Preview for viseron canceled.

Name Link
🔨 Latest commit ae3d6de
🔍 Latest deploy log https://app.netlify.com/sites/viseron/deploys/676743fe7516e400082b2af9

@roflcoopter roflcoopter merged commit 0b91139 into dev Dec 21, 2024
18 checks passed
@roflcoopter roflcoopter deleted the feature/face-recognition-import branch December 21, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recordings visible in the WebUI, but not present in the configured directory
1 participant
@roflcoopter