Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract chart from ninjabot core #124

Open
rodrigo-brito opened this issue Mar 31, 2022 · 3 comments
Open

Extract chart from ninjabot core #124

rodrigo-brito opened this issue Mar 31, 2022 · 3 comments
Labels
env/frontend kind/improvement Refactorings, improvements and tunning

Comments

@rodrigo-brito
Copy link
Owner

We have some issues with the evolution of the Javascript Module. We can use only vanilla JS because it's is compiled in runtime with ES Build.

A good approach will be an isolated development of Chart Module. Then, we can use complex components with modern libraries such as React / Vue.

The chart in Ninjabot core will work exactly as it does now. But, it will include only a simple HTML template with an external import.
@rodrigo-brito rodrigo-brito added kind/improvement Refactorings, improvements and tunning env/frontend labels Mar 31, 2022
@rodrigo-brito rodrigo-brito changed the title Separete chart from ninjabot core Extract chart from ninjabot core Apr 6, 2022
@rodrigo-brito rodrigo-brito mentioned this issue Jul 2, 2022
Closed
@ramilexe
Copy link
Contributor

ramilexe commented Jun 18, 2024 •
edited
Loading

Hi @rodrigo-brito
I implemented integration with TradingView charts. Is it something you might be interested in?

@ramilexe
Copy link
Contributor

image
image

@rodrigo-brito
Copy link
Owner Author

It looks interesting! Can you share the code?
Which version of the library did you use? I remember there were some distribution permission issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
env/frontend kind/improvement Refactorings, improvements and tunning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramilexe @rodrigo-brito