Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to MySQL has changed the API #96

Closed
kodimatrix opened this issue Feb 5, 2024 · 4 comments
Closed

Migration to MySQL has changed the API #96

kodimatrix opened this issue Feb 5, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@kodimatrix
Copy link

Since issue #90, all responses now include the id field. However, this change, which affects backward compatibility, is not documented in the current documentation.
@melosh101
Copy link
Collaborator

melosh101 commented Feb 5, 2024 •
edited
Loading

This is intentional, and is to help with fixing typos, incorrect info and other issues with each specific quote.
Related issue #72

@melosh101 melosh101 added question Further information is requested documentation Improvements or additions to documentation labels Feb 5, 2024
@rocktimsaikia
Copy link
Collaborator

Backward compatibility concern is valid depending on how people have coded their program to use the API. Most likely adding a new field should not break stuff but we should update the website docs for this new change. A PR is welcome for this.

@kodimatrix
Copy link
Author

Completely agree

@kodimatrix
Copy link
Author

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rocktimsaikia @melosh101 @kodimatrix