Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite warning as part of the import capabilities of a command #104

Open
JavaLudwig opened this issue Oct 21, 2022 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@JavaLudwig
Copy link

Artifacts exported are at this time on import overwriting artifacts with the same name. Suggestion to add a warning and required user confirmation or a "force overwrite flag" in case the target system has an artifact with the same name.

@JavaLudwig JavaLudwig added the enhancement New feature or request label Oct 21, 2022
@vscheuber
Copy link
Contributor

@JavaLudwig @atomicsamurai I'd like to discuss this in more depth:

The thinking behind the current way of operation is:

  • frodo is a CI/CD tool, hence user interaction should be minimal
  • the UI supports import of journeys (there is a format incompatibility which we need to work out) and provides a graphical interface showing all the collisions and overwrites and allows the admin to pick exactly what to import and what not.
  • frodo supports the --no-deps flag with the journey export/import commands that allows and admin to bring in only the journey none of the dependencies
  • I believe that in 9/10 cases, the admin wants to overwrite what's already there, because if they don't, they have NO guarantees the imported artifacts will work in the intended way.
  • Because of the previous point, the --force option would likely have to be used almost always.

So those were some of the reasons NOT to do this enhancement request. Here is a reason why we should consider doing it:

  • We should consider applying the "do no harm" principle, which suggests that default actions are not harmful to the system.

@JavaLudwig
Copy link
Author

JavaLudwig commented Oct 24, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants