-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwrite warning as part of the import capabilities of a command #104
Labels
enhancement
New feature or request
Comments
@JavaLudwig @atomicsamurai I'd like to discuss this in more depth: The thinking behind the current way of operation is:
So those were some of the reasons NOT to do this enhancement request. Here is a reason why we should consider doing it:
|
Happy to discuss.
The request came actually up out of the current engagement.
Agree that artifact consistency wrt dependencies should be highest priority.
If needed we could jump on a call. Cal is open.
Regards
Peter
…On Mon, Oct 24, 2022 at 13:29 Volker Scheuber ***@***.***> wrote:
@JavaLudwig <https://github.com/JavaLudwig> @atomicsamurai
<https://github.com/atomicsamurai> I'd like to discuss this in more depth:
The thinking behind the current way of operation is:
- frodo is a CI/CD tool, hence user interaction should be minimal
- the UI supports import of journeys (there is a format
incompatibility which we need to work out) and provides a graphical
interface showing all the collisions and overwrites and allows the admin to
pick exactly what to import and what not.
- frodo supports the --no-deps flag with the journey export/import
commands that allows and admin to bring in only the journey none of the
dependencies
- I believe that in 9/10 cases, the admin wants to overwrite what's
already there, because if they don't, they have NO guarantees the imported
artifacts will work in the intended way.
- Because of the previous point, the --force option would likely have
to be used almost always.
So those were some of the reasons NOT to do this enhancement request. Here
is a reason why we should consider doing it:
- We should consider applying the "do no harm" principle, which
suggests that default actions are not harmful to the system.
—
Reply to this email directly, view it on GitHub
<#104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3XK2AAHAYPRLVBL26PU2VDWE3PR5ANCNFSM6AAAAAARLOL4WQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Artifacts exported are at this time on import overwriting artifacts with the same name. Suggestion to add a warning and required user confirmation or a "force overwrite flag" in case the target system has an artifact with the same name.
The text was updated successfully, but these errors were encountered: