Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency warnings (roc-plugin-react) #35

Open
schibsted-martin opened this issue Jun 4, 2018 · 0 comments
Open

Remove dependency warnings (roc-plugin-react) #35

schibsted-martin opened this issue Jun 4, 2018 · 0 comments

Comments

@schibsted-martin
Copy link
Contributor

Currently there is a fair bit of (wasted) output because we get a warning about exporting react and react-dom from roc-plugin-react.

  Warning    Dependencies


  You have some dependencies in your package.json that also have been exported by extensions. This is probably a mistake.


  Roc will prioritize the ones exported by the extensions.

  You can override this by adding "#" to the start of the require/import in the code, see documentation for more info.


  Dependencies that is both exported and in the projects package.json:

  - react from roc-plugin-react with version IGNORE THE WARNING THAT YOU SEE

  - react-dom from roc-plugin-react with version IGNORE THE WARNING THAT YOU SEE

Is there an easy way to get rid of this message; other than removing the actual export from the library (will require a pull request) - assuming that everyone knows this is a peer dependency and that we always will have this installed as per suggestion by the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant