Skip to content

Rename server key in config to cacheServerUrl #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coryhouse
Copy link

@coryhouse coryhouse commented Jul 17, 2025

The server key is ambiguous, especially since a web app has a webserver, a push endpoint which might be on a different server, and likely other servers. So, suggest renaming to clarify.

If this is accepted, then I suggest updating example apps to reference the Vite env var like this:

const z = new Zero({
  userID,
  auth: () => encodedJWT,
  cacheServerUrl: import.meta.env.VITE_ZERO_CACHE_SERVER_URL, 
  schema,
});

(hello-zero currently uses VITE_PUBLIC_SERVER which is ambiguous)

The current name is ambiguous. I also have a webserver for hosting my app, a push endpoint that some might consider a server, etc, so suggest renaming to clarify.
Copy link

vercel bot commented Jul 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zero-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2025 10:51pm

@coryhouse coryhouse changed the title Update add-to-existing-project.mdx Rename server key in config to cacheServerUrl Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant