Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes workload is undefined in Notification Grouping #1681

Open
SergiiBieliaievskyi opened this issue Jan 7, 2025 · 3 comments
Open

Comments

@SergiiBieliaievskyi
Copy link

Describe the bug
Here is slack sink configuration:

- slack_sink:
    name: main_slack_sink
    slack_channel: alerts-xxxx
    api_key: "{{ env.MAIN_SLACK_SINK }}"
    grouping:
      group_by:
      - workload
      - severity
      interval: 86400
      notification_mode:
        summary:
          threaded: true
          by:
          - workload
          - severity

Nofifications are sent but if pod was killed by OOM or crush reason is CrashLoopBackOff. worload is undefined.

Matching criteria: severity: HIGH, workload: (undefined)

To Reproduce
See above

Expected behavior
As far as I understand the worload name is the name of a parent object ["Deployment", "ReplicaSet", "DaemonSet", "StatefulSet", "Pod", "Job"]:

event.operation in [K8sOperationType.CREATE, K8sOperationType.UPDATE]
        and event.obj.kind in ["Deployment", "ReplicaSet", "DaemonSet", "StatefulSet", "Pod", "Job"]

I expect the name of the parent object has to be assigned to the workload name.

Screenshots
image

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Slack client
  • Version [e.g. 22]

Smartphone (please complete the following information):
Not applicable.

Additional context
Add any other context about the problem here.

Copy link

github-actions bot commented Jan 7, 2025

Hi 👋, thanks for opening an issue! Please note, it may take some time for us to respond, but we'll get back to you as soon as we can!

  • 💬 Slack Community: Join Robusta team and other contributors on Slack here.
  • 📖 Docs: Find our documentation here.
  • 🎥 YouTube Channel: Watch our videos here.

@arikalon1
Copy link
Contributor

Hi @SergiiBieliaievskyi

Thanks for reporting this
Do you have the actual notification in the thread?
Can you share it?

@SergiiBieliaievskyi
Copy link
Author

Hello. Thank you for quick response. Here is full notification:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants