Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KRR computes recommendation for lots of Kubernetes objects, but if just one errors out no results are printed #301

Closed
matheuscscp opened this issue Jun 20, 2024 · 5 comments

Comments

@matheuscscp
Copy link

matheuscscp commented Jun 20, 2024

Describe the bug
KRR computes recommendations for lots of Kubernetes objects but if just one errors out, no useful results are printed.

To Reproduce
Steps to reproduce the behavior:

  1. Have an unstable Prometheus cluster
  2. Run krr simple
  3. Observe that even though lots of INFO Calculated recommendations for ... lines are printed, if one object errors out, none of these recommendations are printed, only the error/traceback is printed.

Expected behavior
A partial result is printed with the recommendations of the objects for which KRR was able to compute, and a list of errors for the objects that had errors.

Are you interested in contributing a fix for this?
Yes!!

Desktop (please complete the following information):

  • OS: MacBook-Pro 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:30:59 PST 2023; root:xnu-10002.81.5~7/RELEASE_ARM64_T6030 arm64
  • Version: v1.10.0
@aantn
Copy link
Contributor

aantn commented Jun 20, 2024

Strongly in favor of a fix! It would be best to do it on top of the prometheus-workload-loader branch as that has some major changes that will be merged soon.

We would love to receive a PR for this.

aantn added a commit that referenced this issue Jun 28, 2024
@aantn
Copy link
Contributor

aantn commented Jun 28, 2024

Hey, I had an easy test case for this so I fixed it myself. Please test and confirm that this works.

@aantn
Copy link
Contributor

aantn commented Jun 28, 2024

Note that the fix isn't merged yet - it is on #307

@matheuscscp
Copy link
Author

@aantn it works for me! thanks for this fix!!!

@aantn
Copy link
Contributor

aantn commented Jun 28, 2024

Wonderful, happy to hear it!

@aantn aantn closed this as completed Jun 28, 2024
aantn added a commit that referenced this issue Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants