Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not a bug: mavros/b6b9754? #426

Open
gavanderhoorn opened this issue Jun 30, 2021 · 1 comment
Open

not a bug: mavros/b6b9754? #426

gavanderhoorn opened this issue Jun 30, 2021 · 1 comment
Labels

Comments

@gavanderhoorn
Copy link
Member

gavanderhoorn commented Jun 30, 2021

The description of b6b9754 reads as-if the change in mavlink/mavros@b6b9754 fixes a bug identified by a developer.

That commit seems to be part of a "regular" pull request ("inital draft for set_actuator_control plugin", see the list of commits) and seems to just be a fix of a mistake introduced earlier in the same PR (ie: the proposed changes never made it into the repository in their buggy state).

I'm wondering whether this should be marked as a bug. There is no user report, nor a report by a developer. The unfixed code never was part of the repository and was fixed in the same PR.

It doesn't look like we consistently mark such cases as bugs in other repositories (ie: developer fixing his/her own mistake in a subsequent commit of a PR).

@wasowski
Copy link
Collaborator

wasowski commented Jul 7, 2021

My perspective (for the record): the paper is about real bugs in robotics software, not about the quality of releases, or mainline of ROS development. In this sense, b6b9754 is still a valid defect (it has been made, and repaired, just never made it into master).

@gavanderhoorn gavanderhoorn changed the title not a bug: b6b9754? not a bug: mavros/b6b9754? Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants