Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove player from queue feature #14

Open
ghost opened this issue Aug 30, 2019 · 4 comments
Open

remove player from queue feature #14

ghost opened this issue Aug 30, 2019 · 4 comments
Milestone

Comments

@ghost
Copy link

ghost commented Aug 30, 2019

the plugin doesn't remove the player from the queue when he changes his level or dies or by a command, if u join the queue then go to another game then another player joins the queue it teleports both of u to the arena position even if you are inside a diffrent game , this way games will be ruined and glitches will show up, this is very very necessary and i can't use this plugin without this feature.

@robske110
Copy link
Owner

Oh, didn't think of that.
Although not the best solution, I think dieing or level change are very reasonable queue-removal reasons. Will implement this.
Minigames are very complex that way and figuring out when to abort an queue is one of the big problems, as such things should actually be done on a global level (e.g. having a master queue manager, where other mini games kick players out of the queue when they want to add him.)

@robske110 robske110 added this to the 1.0.0 milestone Sep 4, 2019
@ghost
Copy link
Author

ghost commented Sep 4, 2019

i have a better solution, make a join command that teleports them to the arena pos and a leave command that teleports them back to the world's safe spawn , i would use it like this:
i will put a sign and put the join command in it and inside the lobby ill put another sign and put the leave command in it , so when they want to leave they tap the sign (actually join command isn't necessary cuz there's already a sign that does the job)

@ghost
Copy link
Author

ghost commented Sep 8, 2019

when is this going to be implemented?

@ghost
Copy link
Author

ghost commented Sep 30, 2019

@robske110 can u please add this feature? i like this plugin and i want to use it

@robske110 robske110 mentioned this issue Apr 12, 2020
robske110 added a commit that referenced this issue Apr 13, 2020
anything further discussed in #14 is out of scope for the plugin to
handle
A leave command in general should be implemented though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant