Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite in pure python #25

Closed
virtuald opened this issue May 25, 2023 · 1 comment
Closed

Rewrite in pure python #25

virtuald opened this issue May 25, 2023 · 1 comment
Assignees

Comments

@virtuald
Copy link
Member

There are a lot of issues that teams run into because this is a wrapper around C++ dependencies (specifically figuring out where errors are occurring is challenging), and there are also some integration issues that come up with third party libraries that use C++ commands because this is a fork. For 2024 we should rewrite commands in pure python. Goals in this rewrite:

  • Implement many/most of the existing Java/C++ commands tests in python on the existing bindings
  • Integrate mypy checks in CI from the beginning as adding them in later sucks
  • Leverage git-source-track like we did previously to track various upstream changes, may need some updates.

After this is completed, then integration of coroutine ideas can be contemplated more seriously (#12, #24). I think the rewrite should happen first though.

@auscompgeek auscompgeek linked a pull request Aug 5, 2023 that will close this issue
@auscompgeek auscompgeek moved this to Todo in 2024 Season Aug 5, 2023
@auscompgeek auscompgeek moved this from Todo to In Progress in 2024 Season Aug 5, 2023
@virtuald
Copy link
Member Author

virtuald commented Nov 5, 2023

Fixed in #27

@virtuald virtuald closed this as completed Nov 5, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in 2024 Season Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants