add benchmark(bad)

Author: robotomize

bf/bfbits/bits.go

@@ -63,7 +63,9 @@ func (bf *bloomFilter) Add(item []byte) error {
 		}
 
 		idx := int(h.Sum64() % uint64(bf.size))
+		// fmt.Printf("%b", bf.bits[idx/64])
 		bf.bits[idx/64] |= 1 << (idx % 64)
+		// fmt.Printf("%b", bf.bits[idx/64])
 	}
 
 	return nil

bf/bfbits/bits_test.go

@@ -1,9 +1,70 @@
 package bfbits
 
 import (
+	"crypto/rand"
+	"encoding/hex"
+	"runtime"
+	"sync"
 	"testing"
 )
 
+func BenchmarkBloomFilter_Contains(b *testing.B) {
+	filter := NewBloomFilter(100_000_000, WithHashNum(3))
+	wCh := make(chan []byte, 1)
+	rCh := make(chan []byte, 1)
+	wChGroup := sync.WaitGroup{}
+	wChGroup.Add(runtime.NumCPU())
+
+	buf := make([]byte, 16)
+	for i := 0; i < runtime.NumCPU(); i++ {
+		go func() {
+			defer wChGroup.Done()
+			for i := 0; i < 10_000_000/runtime.NumCPU(); i++ {
+				read, err := rand.Read(buf)
+				if err != nil {
+					b.Error(err)
+					return
+				}
+
+				chunk := make([]byte, hex.EncodedLen(16))
+				n := hex.Encode(chunk, buf[:read])
+				wCh <- chunk[:n]
+				rCh <- chunk[:n]
+			}
+		}()
+	}
+
+	go func() {
+		wChGroup.Wait()
+		close(wCh)
+		close(rCh)
+	}()
+
+	wg := sync.WaitGroup{}
+	wg.Add(2)
+	go func() {
+		defer wg.Done()
+		for bytes := range wCh {
+			if err := filter.Add(bytes); err != nil {
+				b.Error(err)
+				return
+			}
+		}
+	}()
+
+	go func() {
+		wg.Done()
+		for bytes := range rCh {
+			if _, err := filter.Contains(bytes); err != nil {
+				b.Error(err)
+				return
+			}
+		}
+	}()
+
+	wg.Wait()
+}
+
 func TestBloomFilter_Add(t *testing.T) {
 	bf := NewBloomFilter(10000, WithHashNum(1))
 

cmd/go-bf/main.go

@@ -1,39 +1,5 @@
 package main
 
-import (
-	"crypto/rand"
-	"encoding/hex"
-	"fmt"
-	"log"
-
-	"github.com/robotomize/go-bf/bf/bfbits"
-)
-
 func main() {
-	filter := bfbits.NewBloomFilter(100_000_000, bfbits.WithHashNum(3))
-
-	buf := make([]byte, 8)
-	b := make([][]byte, 5)
-
-	for i := 0; i < 70_000_000; i++ {
-		read, err := rand.Read(buf)
-		if err != nil {
-			return
-		}
-		key := []byte(hex.EncodeToString(buf[:read]))
-		if err := filter.Add(key); err != nil {
-			log.Fatal(err)
-		}
-		if i < len(b) {
-			b[i] = key
-		}
-	}
 
-	for i := 0; i < len(b); i++ {
-		contains, err := filter.Contains(b[i])
-		if err != nil {
-			log.Fatal(err)
-		}
-		fmt.Println(contains)
-	}
 }

examples/main.go

@@ -0,0 +1,22 @@
+package main
+
+import (
+	"fmt"
+
+	"github.com/robotomize/go-bf/bf/bfbits"
+)
+
+func main() {
+	bf := bfbits.NewBloomFilter(10000, bfbits.WithHashNum(1))
+
+	if err := bf.Add([]byte("apple")); err != nil {
+		fmt.Printf("Add() error = %v", err)
+	}
+
+	items := []string{"banana", "cherry", "date"}
+	for _, item := range items {
+		if err := bf.Add([]byte(item)); err != nil {
+			fmt.Printf("Add() error = %v", err)
+		}
+	}
+}