Only generate once

Author: ThadHouse

codehelp/CodeHelpers.Test/LogGeneratorFixerTest.cs

@@ -46,7 +46,7 @@ public partial class MyNewClass
 ";
         testString += InternalTypes;
         fixedCode += InternalTypes;
-        var expected = Verify.Diagnostic(LoggerDiagnostics.MissingGenerateLog).WithLocation(4, 22).WithArguments(["Variable", "MyNewClass"]);
+        var expected = Verify.Diagnostic(LoggerDiagnostics.MissingGenerateLog).WithLocation(4, 22).WithArguments(["MyNewClass"]);
         await Verify.VerifyCodeFixAsync(testString, expected, fixedCode);
     }
 }

codehelp/CodeHelpers/LogGenerator/Analyzer/LogGeneratorAnalyzer.cs

@@ -37,23 +37,6 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context)
             return;
         }
 
-        // Enumerate all members to check for [Log] without [GenerateLog]
-        foreach (var member in namedTypeSymbol.GetMembers())
-        {
-            if (!member.HasLogAttribute())
-            {
-                continue;
-            }
-
-            if (!namedTypeSymbol.HasGenerateLogAttribute())
-            {
-                foreach (var location in namedTypeSymbol.Locations)
-                {
-                    context.ReportDiagnostic(Diagnostic.Create(LoggerDiagnostics.MissingGenerateLog, location, member.Name, namedTypeSymbol.ToDisplayString()));
-                }
-            }
-        }
-
         List<(FailureMode, ISymbol)> failures = [];
         Dictionary<LoggableMember, ISymbol> symbolMap = [];
 

codehelp/CodeHelpers/LogGenerator/Analyzer/LoggerDiagnostics.cs

@@ -45,7 +45,7 @@ public class Ids
     public static readonly DiagnosticDescriptor UnknownSpecialTypeIntArray = new(
         Ids.UnknownSpecialTypeIntArray, "Loggable member has invalid integer type for array use", "[Log] attribute cannot be applied to member '{0}'. Cannot log arrays of type '{1}'. Can only log arrays of 'long'.", Category, DiagnosticSeverity.Error, isEnabledByDefault: true, "");
     public static readonly DiagnosticDescriptor MissingGenerateLog = new(
-        Ids.MissingGenerateLog, "Type has Log member but is not GenerateLog", "Member '{0}' has [Log] attribute, however containing type {1} is not attributed with [GenerateLog]. No logging will be generated for this member.", Category, DiagnosticSeverity.Error, isEnabledByDefault: true, "");
+        Ids.MissingGenerateLog, "Type has Log member but is not GenerateLog", "Type {0} has a member annotated with [Log], but is not attributed with [GenerateLog]. No logging will be generated for this type.", Category, DiagnosticSeverity.Error, isEnabledByDefault: true, "");
 
     public static void ReportDiagnostic(this SymbolAnalysisContext context, FailureMode failureMode, ISymbol symbol)
     {

codehelp/CodeHelpers/LogGenerator/LoggableType.cs

@@ -124,6 +124,14 @@ public static void ExecuteAnalysis(this LoggableType? maybeType, SymbolAnalysisC
                 // We're errored
                 context.ReportDiagnostic(failureMode, symbolMap[call]);
             }
+
+            if (!loggableType.LoggableMembers.IsEmpty && !context.Symbol.HasGenerateLogAttribute())
+            {
+                foreach (var location in context.Symbol.Locations)
+                {
+                    context.ReportDiagnostic(Diagnostic.Create(LoggerDiagnostics.MissingGenerateLog, location, context.Symbol.ToDisplayString()));
+                }
+            }
         }
     }