Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for plugins/themes to require wp-less via composer #66

Open
dantman opened this issue Feb 13, 2014 · 3 comments
Open

Allow for plugins/themes to require wp-less via composer #66

dantman opened this issue Feb 13, 2014 · 3 comments

Comments

@dantman
Copy link

dantman commented Feb 13, 2014

It would be nice if I could composer require wp-less from a plugin or theme folder as a way of installing wp-less.

Currently due to the "type": "wordpress-plugin" if you try this wp-less will end up in /wp-content/themes/{yourtheme}/wp-content/plugins/wp-less and wp-less' dependencies will be put in /wp-content/themes/{yourtheme}/vendor. wp-less.php is not designed for this structure as it expects that either it's a plugin or that the vendor folder is relative to it.

@roborourke
Copy link
Owner

@tarendai made this repo work with composer so I'll have to get him to chime in here :)

@tomjn
Copy link
Contributor

tomjn commented Apr 28, 2014

The problem here is that you would need to make changes that would break things for everybody else.

To use an analogy, what you're requesting is like saying a car wheel requires a sunroof assembly to function when assembling just the wheel. When assembling a full WP stack, you're assembling a car, but we're thinking about it from the wrong way round here with just the wheel.

Instead require wp-less from your theme and plugin, then require your theme/plugin from the main WordPress project, wp-less will be pulled in and installed in the appropriate location. Such a composer.json would go in the WP root ( it needn't manage every plugin and every theme, and WP Core itself though ).

The alternative is to specify a parent folder, but that would change the composer.json and break things for everyone else.

@nhobi
Copy link

nhobi commented Dec 18, 2016

This definitely needs to happen :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants