Don't Require API Keys for Public Workflows #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeldarby
changed the title
yeldarby
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
probicheaux and
hansent
as code owners
PawelPeczek-Roboflow
approved these changes
Nov 28, 2024
grzegorz-roboflow
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working on updates to our backend API that allow serving "Public" Workflows from our backend that won't require an API Key to pull the spec down so we can have better examples in our README and docs that don't require a Roboflow account.
These changes allow our client & server to pass off the key requirement logic to the API.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Against our staging API & tests still pass.
Any specific deployment considerations
Needs the change to our backend API deployed to prod first; separate PR for that in our backend repo.
Docs