Sv detections in core blocks #392
Conversation
| @@ -93,10 +129,11 @@ def anchor_prediction_detections_in_parent_coordinates( | |||
|
|
|||
| def anchor_detections_in_parent_coordinates( | |||
There was a problem hiding this comment.
[loud thinking] what happens with parent detection when we want to modify a detection? is not that expected that when we shift or filter - the exact same thing happens for parent?
could we even address this with sv.Detections? at first, I thought about having it nested somehow, but that seems to be hacky and unclear as the idea. Getting into conclusion that maybe we should just keep shift_x, shift_y as metadata of each detection and only execute this op when needed (basically the only need is while output construction) - then the processing gets more light-weight, as we do not need to perform laborious ops each step
inference/core/workflows/core_steps/transformations/detection_filter.py
Outdated
Show resolved
Hide resolved
inference/core/workflows/core_steps/transformations/detection_filter.py
Outdated
Show resolved
Hide resolved
tests/workflows/unit_tests/core_steps/transformations/test_crop.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We need to get rid of outputs like parent_id, image, prediction_type from blocks:
- YoloWorld
RoboflowInstanceSegmentationModelBlockRoboflowKeypointDetectionModelBlockRoboflowObjectDetectionModelBlockBarcodeDetectorBlockQRCodeDetectorBlock
as those can be hidden within sv.Detections
the same applies for detections consensus - but not sure of that one was changed
grzegorz-roboflow
force-pushed
the
sv-detections-in-core-blocks
branch
from
81b0ee8
to
17b69fb
Compare
grzegorz-roboflow
changed the base branch from
main
to
feature/sv_detections_in_workflows
…etections; refactor all blocks that produce predictions; refactor RoboflowKeypointDetectionModelBlock to include all properties of keypoints within sv.Detections.data
grzegorz-roboflow
force-pushed
the
sv-detections-in-core-blocks
branch
from
f4967f5
to
125570b
Compare
grzegorz-roboflow
merged commit e32e349
into
feature/sv_detections_in_workflows
Description
Migrate blocks to use sv.Detections for storing results of inference.
Non-standard fields (i.e.
key-points,parent_id, etc.) are stored indatasupervision added to list of dependencies.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Workflows created to test each block
Any specific deployment considerations
N/A
Docs
Docs need to be updated