Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perl 5.10 listed as the minimum Perl version but uses 5.14 package block syntax in lib/Slack/Notify.pm #4

Open
jwrightecs opened this issue Jul 22, 2020 · 0 comments
Open

Perl 5.10 listed as the minimum Perl version but uses 5.14 package block syntax in lib/Slack/Notify.pm #4

jwrightecs opened this issue Jul 22, 2020 · 0 comments

Comments

@jwrightecs
Copy link
Contributor

Also the tests seem to succeed on 5.10 despite that, only triggering the error on code using the module
Should adjust the minimum perl version or revert to using the { package NAME; } syntax instead
jwrightecs added a commit to jwrightecs/Slack-Notify that referenced this issue Aug 5, 2020
@jwrightecs
robn#4 : Use 5.10 compatible package; BLOCK syntax
2a4b0ce
@jwrightecs jwrightecs mentioned this issue Aug 5, 2020
Merged
robn added a commit that referenced this issue Mar 30, 2022
@robn
Merge pull request #5 from jwrightecs/master
5d93438 
#4 : Use 5.10 compatible package; BLOCK syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwrightecs