Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article command? #12

Open
Anahkiasen opened this issue Oct 25, 2015 · 4 comments
Open

Article command? #12

Anahkiasen opened this issue Oct 25, 2015 · 4 comments

Comments

@Anahkiasen
Copy link
Contributor

I didn't find a way to get an article's contents from the package, through the ARTICLE command, is it not possible without writing my own implementation?

@Anahkiasen
Copy link
Contributor Author

Ok figured out how to do it from the existing commands, actually simpler than I thought. Would be nice to have it in core though, feel like BODY and ARTICLE should be pretty common use cases

@Anahkiasen
Copy link
Contributor Author

Gonna do a PR with the ARTICLE command later but it's a more complicated one.

@Anahkiasen
Copy link
Contributor Author

Actually not sure about something, should an ARTICLE command just return the contents from the socket or should it clean it up in some way? On the project I use php-nntp on I have a class dedicated for that but not sure if most of it is not specific to news.php.net

@robinvdvleuten
Copy link
Owner

It is intended to do some small cleanups, I should check that in my own project. I extracted it at first from a project I started which indexes NZB newsgroups and the inspiration came from the Net_NNTP library (github).
I want to mimic their output as close as possible so that library can be easily replaced with mine. So checkout this line to see how the output of the command should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants