Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection strings containing special URL encoding characters are mangled #42

Open
ckpearson opened this issue Oct 24, 2023 · 2 comments
Labels
Azure Blob bug Something isn't working

Comments

@ckpearson
Copy link

When trying to create an azure blob storage instance from a connection string, if the key contains a '+' this fails with the cryptic "not a valid base64 value".

After digging around and creating an instance of StorageConnectionString myself and looking at the code, I can see the value of each part gets url decoded.

The documentation does not mention this at all, so either the code should leave the value as-is, or the documentation should be very clear that the secret value needs to be url-encoded.

Might be helpful having an exception in there too to catch this scenario and warn the user that they need to encode the value.

@ckpearson
Copy link
Author

#10 also covers this and was IMO closed prematurely.

@robinrodricks
Copy link
Owner

Can you help locate the code which does this and suggest how the fix should be implemented?

@robinrodricks robinrodricks added bug Something isn't working Azure Blob labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure Blob bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants