Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed of == operator overload #347

Open
andrewarrow opened this issue Jul 25, 2022 · 6 comments
Open

speed of == operator overload #347

andrewarrow opened this issue Jul 25, 2022 · 6 comments

Comments

@andrewarrow
Copy link

Hello, new to Cartography but I work at a company with a large iOS codebase and they have forked it and replaced == with ~==. Why? Because they found the speed increase in xcode a huge win. i.e. because xcode is doing extra stuff with the normal == (trying to apply normal rules to left and right side of the operator) it slows down a lot once you have > N lines of code.

I suspect many users of Cartography would never notice this speed issue unless their codebase is very large. But wondering if anyone else has seen this and if there is any plan move away from the == ?

Thanks!

@anomaddev
Copy link

I just forked the current version and added the relevant code to change the '==' to '~=='. See #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@andrewarrow @anomaddev and others