You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When browse-at-remote encounters a file whose url cannot be resolved (e.g. is untracked, or on an untracked branch, etc), an error occurs and that's that. I'd like to suggest one of the following as alternatives:
It falls back to a default branch. Either master, or from a variable like browse-at-remote-default-branch.
Have browse-at-remote/get-url or browse-at-remote/file-url accept an optional branch argument, then we can write it ourselves.
Or it falls back to the root of the repository.
The rationale is that when I use browse-at-remote, I have a good idea of where I want to end up. If it doesn't find the exact url, I find it preferrable that it take me somewhere close to the target, rather than stop me dead in my tracks with an error.
I'd be happy to do a PR for this, if you'll let me know which approach (or another) you'd prefer.
Let me know! And thanks for this plugin by the way!
The text was updated successfully, but these errors were encountered:
When browse-at-remote encounters a file whose url cannot be resolved (e.g. is untracked, or on an untracked branch, etc), an error occurs and that's that. I'd like to suggest one of the following as alternatives:
master
, or from a variable likebrowse-at-remote-default-branch
.browse-at-remote/get-url
orbrowse-at-remote/file-url
accept an optionalbranch
argument, then we can write it ourselves.The rationale is that when I use browse-at-remote, I have a good idea of where I want to end up. If it doesn't find the exact url, I find it preferrable that it take me somewhere close to the target, rather than stop me dead in my tracks with an error.
I'd be happy to do a PR for this, if you'll let me know which approach (or another) you'd prefer.
Let me know! And thanks for this plugin by the way!
The text was updated successfully, but these errors were encountered: