Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from review #1

Open
rmglennon opened this issue Apr 17, 2018 · 0 comments
Open

Feedback from review #1

rmglennon opened this issue Apr 17, 2018 · 0 comments

Comments

@rmglennon
Copy link
Owner

  • for fun look into ternary operator for conditionals that are either true or false : https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Conditional_Operator

  • you can append multiple items to the an other element at once, just separate the values by a comma

    foodDiv.append(ratingText);
    foodDiv.append(foodImage);

    foodDiv.append(ratingText, foodImage);

  • very nice work!

  • make sure that users can not submit the same value more than once. when a food is added lowercase it and check if its already in the array if it is display a message to your user to add something else and remove the message when they click into the input again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant