-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Description
The HandleDNSRequest function does not correctly handle DNS requests containing multiple questions, as noted by the FIXME comment. The current logic iterates through questions and returns immediately upon the first blocked domain or cache hit. A valid DNS response must address all questions in the request. This will lead to incorrect behavior for clients that send multi-question requests.
The handler needs to be refactored to build a single response message that contains answers for all questions. This would involve iterating through all questions, collecting answers (from cache or upstream), handling blocked domains for each, and then assembling a final dns.Msg to send back.
Metadata
Metadata
Assignees
Labels
No labels