Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chap-9 Output graph is rotated. #488

Open
bhuiyan-rifat opened this issue Jan 6, 2024 · 0 comments
Open

chap-9 Output graph is rotated. #488

bhuiyan-rifat opened this issue Jan 6, 2024 · 0 comments

Comments

@bhuiyan-rifat
Copy link

bhuiyan-rifat commented Jan 6, 2024

*Input graph is rotated

chap-9 uses a function from ""from kf_book.nonlinear_plots import plot_nonlinear_func""
where in the 'input' histogram the xs and ys got replaced and the graph is rotated 90 degrees clockwise. Was it intentional?
I see in plot_nonlinear_func for input graph the histogram plot is written as
plt.plot(h[0], h[1][1:], lw=2....)
instead of
plt.plot(h[1][1:], h[0], lw=2...)

Was it intentional?
We are comparing the noise before and after applying nonlinear function so they should be similarly oriented to see, right?
this is what it looks like
image

this is what it should look like(I think)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant