Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] PluginBundle::Easy: add "log" and "log_fatal" methods [rt.cpan.org #135305] #697

Open
rjbs opened this issue Jul 3, 2021 · 0 comments

Comments

@rjbs
Copy link
Owner

rjbs commented Jul 3, 2021

https://rt.cpan.org/Ticket/Display.html?id=135305

Hello,

I can't use the GitHub issue tracker to report this, since I don't have
a GitHub account. Hopefully this is ok instead, and sorry for any
inconvenience!

As I said on #distzilla, there are no "log" or "log_fatal" methods for
plugin bundles. The attached patch implements these methods for
Dist::Zilla::Role::PluginBundle::Easy.

These methods could also be implemented for
Dist::Zilla::Role::PluginBundle, but that would require moving the
"name" attribute from PluginBundle::Easy to PluginBundle. So maybe it's
best to implement the logging methods in PluginBundle::Easy and keep
PluginBundle as a minimal role.

The logging methods added in my patch are simply wrappers around "die"
and "warn", nothing more.

Find my patch below:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant