Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GsimRupture initialized for each magnitude (new smtk) vs only once (old smtk) #40

Open
rizac opened this issue Oct 10, 2023 · 0 comments
Assignees

Comments

@rizac
Copy link
Owner

rizac commented Oct 10, 2023

Tests of Trellis vs magnitude do not produce the same results as in old smtk. Reason is that for each magnitude we initialize now a new Gsimrupture, whereas in the old code it seem that we initialized only one rupture for all magnitudes:

https://github.com/GEMScienceTools/gmpe-smtk/blob/7948682b32ef804a52d266dfcc94512da01149ab/smtk/trellis/trellis_plots.py#L434C9-L439C61

The behavior looks right in the new version and a bug in the old one, but I need confirmation for this
(@g-weatherill no need to reply here, we'll discuss in the next days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants