Skip to content

Commit 1dcd4d9

Browse files
authored
fix(core): threw error if option was not passed (#260)
* fix(core): threw error if option was not passed fix #256 * v5.0.3-0
1 parent bc817e3 commit 1dcd4d9

File tree

29 files changed

+1172
-1461
lines changed

29 files changed

+1172
-1461
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,4 @@ stats.html
1111
**/umd
1212
**/.DS_Store
1313
lerna-debug.log
14+
**/package-lock.json

index.html

Lines changed: 0 additions & 76 deletions
This file was deleted.

lerna.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
"packages": [
44
"packages/*"
55
],
6-
"version": "5.0.2"
6+
"version": "5.0.3-0"
77
}

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,5 +91,6 @@
9191
},
9292
"bugs": {
9393
"url": "https://github.com/ritz078/embed.js/issues"
94-
}
94+
},
95+
"dependencies": {}
9596
}

packages/embed-js/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "embed-js",
3-
"version": "5.0.2",
3+
"version": "5.0.3-0",
44
"description": "The base plugin that can be used to create custom plugins.",
55
"main": "dist/index.js",
66
"module": "src/index.js",
@@ -19,10 +19,10 @@
1919
"dependencies": {
2020
"is-dom": "^1.0.9",
2121
"is-in-browser": "1.1.3",
22-
"just-extend": "^1.1.22",
22+
"just-extend": "1.1.27",
2323
"p-waterfall": "^1.0.0"
2424
},
2525
"devDependencies": {
26-
"embed-preset-basic": "^5.0.2"
26+
"embed-preset-basic": "^5.0.3-0"
2727
}
2828
}

packages/embed-js/tests/embed.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import EmbedJS from "../src"
22
import test from "ava"
33
import prismjs from "prismjs"
4-
import embedAll from "embed-preset-basic"
4+
import basic from "embed-preset-basic"
55

66
const input = `
77
Sunt eraes Cum habitio messis, omnes rectores resuscitabo brevis, bassus gabaliumes.Altus cliniass ducunt ad extum.Sunt habitioes imperium brevis, https://github.com/ritz078/embed.js bassus elogiumes.Pol, a bene fides.Calceus varius lacta est.Nunquam prensionem detrius.Verpa raptus abactus est.Eleates crederes, tanquam rusticus fuga.Cur classis cantare?Bassus musa rare attrahendams bursa est.Pol, mirabilis gallus!Accelerare sensim ducunt ad raptus onus.Bubos peregrinatione! imitari :smile: dexter, https://soundcloud.com/traphousemusic1/despacito-luis-fonsi-daddy-yankee fatalis parses.Mineraliss sunt parss de pius finis.Hippotoxotas ire in quadrata!Ionicis tormentos congregabo in copinga!Fluctuis peregrinatione!Navis, pulchritudine, et devatio.Calceuss cadunt in dexter gandavum!Amor, solitudo, et
@@ -16,7 +16,7 @@ Sunt eraes Cum habitio messis, omnes rectores resuscitabo brevis, bassus gabaliu
1616
test("EmbedJS - should return correct result", async t => {
1717
const ejs = new EmbedJS({
1818
input,
19-
preset: embedAll({
19+
preset: basic({
2020
gAuthKey: "AIzaSyCqFouT8h5DKAbxlrTZmjXEmNBjC69f0ts",
2121
highlight: {
2222
prismjs

packages/embed-js/tests/snapshots/embed.test.js.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Generated by [AVA](https://ava.li).
99
> Snapshot 1
1010
1111
`␊
12-
Sunt eraes Cum habitio messis, omnes rectores resuscitabo brevis, bassus gabaliumes.Altus cliniass ducunt ad extum.Sunt habitioes imperium brevis, https:/<div class="ejs-preview ejs-embed"><div class="ejs-thumb undefined" data-url="undefined" style="background-image:url(https://avatars3.githubusercontent.com/u/5389035?v=4)"><span>&#9658;</span></div><div class="ejs-info"><h4 class="ejs-title"><a href="https://github.com/ritz078/embed-js">ritz078/embed-js</a></h4><div class="ejs-desc">🌻 A lightweight plugin to embed emojis, media, maps, tweets, code and more. ✨</div></div></div> bassus elogiumes.Pol, a bene fides.Calceus varius lacta est.Nunquam prensionem detrius.Verpa raptus abactus est.Eleates crederes, tanquam rusticus fuga.Cur classis cantare?Bassus musa rare attrahendams bursa est.Pol, mirabilis gallus!Accelerare sensim ducunt ad raptus onus.Bubos peregrinatione! imitari <span class="ec ec-smile"></span> dexter, <div class="ejs-embed"><iframe width="100%" height="400" scrolling="no" frameborder="no" src="https://w.soundcloud.com/player/?visual=true&url=http%3A%2F%2Fapi.soundcloud.com%2Ftracks%2F191477804&show_artwork=true"></iframe></div> fatalis parses.Mineraliss sunt parss de pius finis.Hippotoxotas ire in quadrata!Ionicis tormentos congregabo in copinga!Fluctuis peregrinatione!Navis, pulchritudine, et devatio.Calceuss cadunt in dexter gandavum!Amor, solitudo, et␊
12+
Sunt eraes Cum habitio messis, omnes rectores resuscitabo brevis, bassus gabaliumes.Altus cliniass ducunt ad extum.Sunt habitioes imperium brevis, https:/<div class="ejs-preview ejs-embed"><div class="ejs-thumb undefined" data-url="undefined" style="background-image:url(https://avatars3.githubusercontent.com/u/5389035?v=4)"></div><div class="ejs-info"><h4 class="ejs-title"><a href="https://github.com/ritz078/embed-js">ritz078/embed-js</a></h4><div class="ejs-desc">🌻 A lightweight plugin to embed emojis, media, maps, tweets, code and more. ✨</div></div></div> bassus elogiumes.Pol, a bene fides.Calceus varius lacta est.Nunquam prensionem detrius.Verpa raptus abactus est.Eleates crederes, tanquam rusticus fuga.Cur classis cantare?Bassus musa rare attrahendams bursa est.Pol, mirabilis gallus!Accelerare sensim ducunt ad raptus onus.Bubos peregrinatione! imitari <span class="ec ec-smile"></span> dexter, <div class="ejs-embed">undefined</div> fatalis parses.Mineraliss sunt parss de pius finis.Hippotoxotas ire in quadrata!Ionicis tormentos congregabo in copinga!Fluctuis peregrinatione!Navis, pulchritudine, et devatio.Calceuss cadunt in dexter gandavum!Amor, solitudo, et␊
1313
<pre class="language-js"><code class="language-js"><span class="token punctuation">.</span>ejs<span class="token operator">-</span>embed iframe <span class="token punctuation">{</span>␊
1414
width<span class="token punctuation">:</span> <span class="token number">100</span><span class="token operator">%</span><span class="token punctuation">;</span>␊
1515
<span class="token punctuation">}</span></code></pre>␊
Binary file not shown.

packages/embed-plugin-base/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "embed-plugin-base",
3-
"version": "5.0.2",
3+
"version": "5.0.3-0",
44
"description": "The base plugin that can be used to create custom plugins.",
55
"main": "dist/index.js",
66
"module": "src/index.js",
@@ -17,7 +17,7 @@
1717
},
1818
"homepage": "https://github.com/ritz078/embed.js#readme",
1919
"dependencies": {
20-
"embed-plugin-utilities": "^5.0.2",
21-
"just-extend": "^1.1.22"
20+
"embed-plugin-utilities": "^5.0.3-0",
21+
"just-extend": "1.1.27"
2222
}
2323
}

packages/embed-plugin-emoji/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "embed-plugin-emoji",
3-
"version": "5.0.2",
3+
"version": "5.0.3-0",
44
"description": "An embed-js plugin to embed emojis supported by emoji.css.",
55
"main": "dist/index.js",
66
"module": "src/index.js",
@@ -22,7 +22,7 @@
2222
},
2323
"homepage": "https://github.com/ritz078/embed.js#readme",
2424
"dependencies": {
25-
"just-extend": "^1.1.22",
25+
"just-extend": "1.1.27",
2626
"just-kebab-case": "^1.0.0",
2727
"regex-emoji": "^2.0.5"
2828
}

0 commit comments

Comments
 (0)