Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the context limits of octave and duration in a repeated figure #131

Open
lpugin opened this issue Jun 5, 2024 · 5 comments
Open
Labels
Type: Spec Clarification Clarifications to existing content in the spec

Comments

@lpugin
Copy link
Contributor

lpugin commented Jun 5, 2024

See full description of the problem here

@lpugin lpugin added the Type: Spec Clarification Clarifications to existing content in the spec label Jun 5, 2024
@ahankinson
Copy link
Contributor

From the linked issue:

I noticed this to be particularly "nasty" with the use of repetition. For example, if you do:

2'G4!G^B^''D!f/ you probably expect the last chord to be repeated like that:
image

However, this is what Verovio produces - keeping the last octave as current:
image

@ahankinson
Copy link
Contributor

ahankinson commented Jul 15, 2024

I would expect that the scoping of the repeat would implicitly re-scope the beginning octave, by the assumption that octave markings can be omitted by the encoder to be more concise, but they are still applied to the context.

So, if you take 2'G4!G^B^''D!f/ and add the implied octave markings and expand the repeat, it becomes 2'G4'G^'B^''D'G^'B^''D/ -- they are equivalent in this expansion. This is what makes the most sense to me, but I'm fully aware that this rule probably hasn't been checked against the other behaviours.

In other words, 2'G4!G^B^''D!f/ expanding to 2'G4'G^'B^''D''G^''B^'''G/ seems pretty weird to me, especially because it very easily can overrun the 4-octave limit if the octaves are additive on every repeat. Edit: I got that wrong...

@ahankinson ahankinson changed the title Clarify that an octave change within a chord remains as current after the chord Clarify that an octave change within a chord does not remain as current in a repeat Jul 15, 2024
@ahankinson ahankinson changed the title Clarify that an octave change within a chord does not remain as current in a repeat Clarify the context limits of octave and duration in a repeated figure Jul 15, 2024
@ahankinson
Copy link
Contributor

Action: Add a note to the shortcuts section to say that the repeated figures are repeated as the musical values given in the first section, and are not continued in the repeat.

@ahankinson
Copy link
Contributor

NB: related to (but not the same as?) #132

@BaMikusi
Copy link
Collaborator

That sounds all good to me (in keeping with our longer discussion in #132).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Spec Clarification Clarifications to existing content in the spec
Projects
None yet
Development

No branches or pull requests

3 participants