Skip to content

Commit

Permalink
fix: bypass cluster limits by default in debug build
Browse files Browse the repository at this point in the history
  • Loading branch information
BugenZhao committed Nov 29, 2024
1 parent 01b703d commit 4c7d174
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 4 additions & 1 deletion src/common/src/session_config/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ type SessionConfigResult<T> = std::result::Result<T, SessionConfigError>;
const DISABLE_BACKFILL_RATE_LIMIT: i32 = -1;
const DISABLE_SOURCE_RATE_LIMIT: i32 = -1;

/// Default to bypass cluster limits iff in debug mode.
const BYPASS_CLUSTER_LIMITS: bool = cfg!(debug_assertions);

#[serde_as]
/// This is the Session Config of RisingWave.
#[derive(Clone, Debug, Deserialize, Serialize, SessionConfig, ConfigDoc, PartialEq)]
Expand Down Expand Up @@ -306,7 +309,7 @@ pub struct SessionConfig {
/// Bypass checks on cluster limits
///
/// When enabled, `CREATE MATERIALIZED VIEW` will not fail if the cluster limit is hit.
#[parameter(default = false)]
#[parameter(default = BYPASS_CLUSTER_LIMITS)]
bypass_cluster_limits: bool,

/// The maximum number of parallelism a streaming query can use. Defaults to 256.
Expand Down
4 changes: 0 additions & 4 deletions src/config/ci-sim.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,3 @@ max_concurrent_creating_streaming_jobs = 0

[meta]
meta_leader_lease_secs = 10

[meta.developer]
meta_actor_cnt_per_worker_parallelism_soft_limit = 65536
meta_actor_cnt_per_worker_parallelism_hard_limit = 65536

0 comments on commit 4c7d174

Please sign in to comment.