Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming ASR permission #106

Closed
arichardson opened this issue Feb 9, 2024 · 6 comments
Closed

Renaming ASR permission #106

arichardson opened this issue Feb 9, 2024 · 6 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested

Comments

@arichardson
Copy link
Collaborator

As has been noted before, ASR grants additional privilege beyond CSR access so the historical "Access System Registers" name may not be the best. Morello uses System which is IMO better, but the abbreviation would conflict with S for Store, maybe Privileged Permission (P)/Elevated Permission (E)/System Management Permission (SM)?

@arichardson arichardson added documentation Improvements or additions to documentation question Further information is requested enhancement New feature or request labels Feb 9, 2024
@tariqkurd-repo
Copy link
Collaborator

What should the spec of ASR be? What additional state does it allow access to over CSRs?

@arichardson
Copy link
Collaborator Author

I guess you could argue that instructions like xret actually read the CSR so ASR isn't needed for the instruction itself but rather the side-effects of that instruction. We can probably ignore this until there is another non-CSR case that needs elevated privilege.

I do wonder if we should require it for ECALL though...

@sorear
Copy link
Contributor

sorear commented Mar 11, 2024

#140 and https://lists.riscv.org/g/sig-cheri/message/68 have a fair amount about other uses for ASR and its fundamental nature as the catch-all for resources, whether architectural or software-defined, accessible in a given privilege mode for which a more specific permission is either not needed or intended to be defined at a higher level using sentries.

Personally of the options given I prefer "Elevated (E)" - Privileged invites confusion with privilege levels, and System Management has implications about resource scope which may not be accurate.

@tariqkurd-repo
Copy link
Collaborator

@arichardson do you want to do something about this one? Or shelve it?

@andresag01
Copy link
Collaborator

@arichardson : Can we close this ticket?

@arichardson
Copy link
Collaborator Author

Let's close this and keep it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants