Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial psABI atomics specification #378

Merged
merged 1 commit into from
Jun 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions introduction.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ This specification uses the following terms and abbreviations:
| XLEN | The width of an integer register in bits
| FLEN | The width of a floating-point register in bits
| Linker relaxation | A mechanism for optimizing programs at link-time, see <<Linker Relaxation>> for more detail.
| RVWMO | RISC-V Weak Memory Order, as defined in the RISC-V specification.
|===

= Status of ABI
Expand Down
2 changes: 2 additions & 0 deletions riscv-abi.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ include::riscv-elf.adoc[]
include::riscv-dwarf.adoc[]

include::riscv-rtabi.adoc[]

include::riscv-atomic.adoc[]
183 changes: 183 additions & 0 deletions riscv-atomic.adoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,183 @@
[[riscv-atomics]]
= RISC-V Atomics ABI Specification
ifeval::["{docname}" == "riscv-atomics"]
include::prelude.adoc[]
endif::[]

== RISC-V atomics mappings

This specifies mappings of C and C\++ atomic operations to RISC-V
machine instructions. Other languages, for example Java, provide similar
facilities that should be implemented in a consistent manner, usually
by applying the mapping for the corresponding C++ primitive.

NOTE: Because different programming languages may be used within the same
process, these mappings must be compatible across programming languages. For
example, Java programmers expect memory ordering guarantees to be enforced even
if some of the actual memory accesses are performed by a library written in
C.

NOTE: Though many mappings are possible, not all of them will interoperate
correctly. In particular, many mapping combinations will not
correctly enforce ordering  between a C++ `memory_order_seq_cst`
store and a subsequent `memory_order_seq_cst` load.

NOTE: These mappings are very similar to those that originally appeared in the
appendix of the RISC-V "unprivileged" architecture specification as
"Mappings from C/C++ primitives to RISC-V Primitives", which we will
refer to by their 2019 historical label of "Table A.6". That mapping may
be used, _except_ that `atomic_store(memory_order_seq_cst)` must have an
an extra trailing fence for compatibility with the "Hypothetical mappings ..."
table in the same section, which we similarly refer to as "Table A.7".
As a result, we allow the "Table A.7" mappings as well.

NOTE: Our primary design goal is to maximize performance of the "Table A.7"
mappings. These require additional load-acquire and store-release instructions,
and are this not immediately usable. By requiring the extra store fence.
or equivalent, we avoid an ABI break when moving to the "Table A.7"
mappings in the future, in return for a small performance penalty in the
short term.

For each construct, we provide a mapping that assumes only the A extension.
In some cases, we provide additional mappings that assume a future load-acquire
and store-release extension, as denoted by note 1 in the table.

All mappings interoperate correctly, and with the original "Table A.6"
mappings, _except_ that mappings marked with note 3 do not interoperate
with the original "Table A.6" mappings.

We present the mappings as a table in 3 sections. The first
deals with translations for loads, stores, and fences. The next two sections
address mappings for read-modify-write operations like `fetch_add`, and
`exchange`. The second section deals with operations that have direct
`amo` instruction equivalents in the RISC-V A extension. The final
section deals with other read-modify-write operations that require
the `lr` and `sc` instructions.

[[tab:c11mappings]]
.Mappings from C/C++ primitives to RISC-V primitives
[cols="<22,<18,<4",options="header",]
|===
|C/C++ Construct |RVWMO Mapping |Notes

|Non-atomic load |`l{b\|h\|w\|d}` |

|`atomic_load(memory_order_relaxed)` |`l{b\|h\|w\|d}` |

|`atomic_load(memory_order_acquire)` |`l{b\|h\|w\|d}; fence r,rw` |

|`atomic_load(memory_order_acquire)` |<RCsc atomic load-acquire> |1, 2

|`atomic_load(memory_order_seq_cst)` |`fence rw,rw; l{b\|h\|w\|d}; fence r,rw` |

|`atomic_load(memory_order_seq_cst)` |<RCsc atomic load-acquire> |1, 3

|Non-atomic store |`s{b\|h\|w\|d}` |

|`atomic_store(memory_order_relaxed)` |`s{b\|h\|w\|d}` |

|`atomic_store(memory_order_release)` |`fence rw,w; s{b\|h\|w\|d}` |

|`atomic_store(memory_order_release)` |<RCsc atomic store-release> |1, 2

|`atomic_store(memory_order_seq_cst)` |`fence rw,w; s{b\|h\|w\|d}; fence rw,rw;` |

|`atomic_store(memory_order_seq_cst)` |`amoswap.rl{w\|d};` |4

|`atomic_store(memory_order_seq_cst)` |<RCsc atomic store-release> |1

|`atomic_thread_fence(memory_order_acquire)` |`fence r,rw` |

|`atomic_thread_fence(memory_order_release)` |`fence rw,w` |

|`atomic_thread_fence(memory_order_acq_rel)` |`fence.tso` |

|`atomic_thread_fence(memory_order_seq_cst)` |`fence rw,rw` |
|===

[cols="<20,<20,<4",options="header",]
|===
|C/C++ Construct |RVWMO AMO Mapping |Notes

|`atomic_<op>(memory_order_relaxed)` |`amo<op>.{w\|d}` |4

|`atomic_<op>(memory_order_acquire)` |`amo<op>.{w\|d}.aq` |4

|`atomic_<op>(memory_order_release)` |`amo<op>.{w\|d}.rl` |4

|`atomic_<op>(memory_order_acq_rel)` |`amo<op>.{w\|d}.aqrl` |4

|`atomic_<op>(memory_order_seq_cst)` |`amo<op>.{w\|d}.aqrl` |4

|===

[cols="<16,<24,<4",options="header",]
|===
|C/C++ Construct |RVWMO LR/SC Mapping |Notes

|`atomic_<op>(memory_order_relaxed)` |`loop:lr.{w\|d}; <op>; sc.{w\|d}; bnez loop` |4

|`atomic_<op>(memory_order_acquire)`
|`loop:lr.{w\|d}.aq; <op>; sc.{w\|d}; bnez loop` |4

|`atomic_<op>(memory_order_release)`
|`loop:lr.{w\|d}; <op>; sc.{w\|d}.rl; bnez loop` |4

|`atomic_<op>(memory_order_acq_rel)`
|`loop:lr.{w\|d}.aq; <op>; sc.{w\|d}.rl; bnez loop` |4

|`atomic_<op>(memory_order_seq_cst)`
|`loop:lr.{w\|d}.aqrl; <op>; sc.{w\|d}.rl; bnez loop` |4

|`atomic_<op>(memory_order_seq_cst)`
|`loop:lr.{w\|d}.aq; <op>; sc.{w\|d}.rl; bnez loop` |3, 4
|===

=== Meaning of notes in table

1) Depends on a load instruction with an RCsc aquire annotation,
or a store instruction with an RCsc release annotation. These are curently
under discussion, but the specification has not yet been approved.

2) An RCpc load or store would also suffice, if it were to be introduced
in the future.

3) Incompatible with the original "Table A.6" mapping. Do not combine these
mappings with code generated by a compiler using those older mappings.
(This was mostly used by the initial LLVM implementations for RISC-V.)

4) Currently only directly possible for 32- and 64-bit operands.

=== Other conventions

It is expected that the RVWMO AMO Mappings will be used for atomic read-modify-write
operations that are directly supported by corresponding AMO instructions,
and that LR/SC mappings will be used for the remainder, currently
including compare-exchange operations. Compare-exchange LR/SC sequences
on the containing 32-bit word should be used for shorter operands. Thus,
a `fetch_add` operation on a 16-bit quantity would use a 32-bit LR/SC sequence.

It is acceptable, but usually undesirable for performance reasons, to use LR/SC
mappings where an AMO mapping would suffice.

Atomics do not imply any ordering for IO operations. IO operations
should include sufficient fences to prevent them from being visibly
reordered with atomic operations.

Float and double atomic loads and stores should be implemented using
the integer sequences.

Float and double read-modify-write instructions should consist of a loop performing
an initial plain load of the value, followed by the floating point
computation, followed by an integer compare-and-swap sequence to try to
Comment on lines +171 to +172
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the same floating-point exception flags be asserted each time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C++ standard says "The floating-point environment (28.3) for atomic arithmetic operations on
floating-point-type may be different than the calling thread’s floating-point environment." That hopefully covers us here sufficiently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it justifies using a different rounding mode for the computation, as well as not reporting all exception flags raised back to the calling thread's fenv. I need more convincing that it allows the atomic implementation to update the calling thread's fenv with exception flags that don't correspond to the particular floating point operation that was ultimately performed. (This feels like it violates sequential consistency.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, it looks like libstdc++ already does what you suggest:
https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/include/bits/atomic_base.h#L1163-L1173

... and I now see that you coauthored https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0020r6.html , which includes the sentence you quoted earlier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. AFAICT, this is an issue with the C++ standard's formulation. I'll ask if Carter remembers some reason this is OK as is.
AFAICT, this is all kind of a mess at the language standards level, so it's unclear how much we can really do here. C++ has fetch_add(), and says a little about exceptions, but probably not enough. On the other hand, the FENV_ACCESS pragma is not generally supported, so this isn't really guaranteed to work. C does not provide floating-point fetch-add, but it does provide atomic +=. And it seems to require that floating point flags are saved and restored. AFAICT, gcc actually does that, but clang doesn't. I think the gcc behavior is much more correct, but I would guess the clang behavior is what's usually desired.
I'll add some minimal weasel-wording.

store back the updated value. This avoids floating point
instructions between LR and SC instructions. Depending on language requirements,
it may be necessary to save and restore floating-point exception flags in the
case of an operation that is later redone due to a failed SC operation.

NOTE: The "Eventual Success of Store-Conditional Instructions" section
in the ISA specification provides that essential progress guarantee only
if there are no floating point instructions between the LR and matching SC
instruction. By compiling such sequences with an "extra" ordinary load,
and performing the floating point computation before the LR, we preserve
the guarantee.