Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: return default malformed-request as a JSON response #72

Open
lavin-ds opened this issue Dec 7, 2023 · 0 comments
Open

Comments

@lavin-ds
Copy link

lavin-ds commented Dec 7, 2023

Hi team 👋🏽

I have been using ring-json in a few of my projects, and have been wondering if it makes sense to return the default malformed response as a JSON response, instead of text in the body. I believe it is useful since most api services expect a JSON response that they try to unmarshall and may fail when making a malformed request. But this is my opinion and may not be true about other projects in the wild.

If you agree with this, I am happy to create a pull request and make the change. I currently override it by providing my own, but was wondering if more people would find it useful.

Looking forward to hearing how you feel about it. Also, I think it's an awesome library regardless of this change 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant