Skip to content

Commit 002814a

Browse files
committed
Remove :same-site :strict default
Browsers default to :lax, which is a more sensible default. Fixes #32.
1 parent dbd622e commit 002814a

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/ring/middleware/defaults.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
:keywordize true}
4343
:cookies true
4444
:session {:flash true
45-
:cookie-attrs {:http-only true, :same-site :strict}}
45+
:cookie-attrs {:http-only true}}
4646
:security {:anti-forgery true
4747
:frame-options :sameorigin
4848
:content-type-options :nosniff}

test/ring/middleware/defaults_test.clj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
(is (= (get-in resp [:headers "Content-Type"]) "application/octet-stream"))
3030
(let [set-cookie (first (get-in resp [:headers "Set-Cookie"]))]
3131
(is (.startsWith set-cookie "ring-session="))
32-
(is (.contains set-cookie "HttpOnly"))
33-
(is (.contains set-cookie "SameSite=Strict")))))
32+
(is (.contains set-cookie "HttpOnly")))))
3433

3534
(testing "default charset"
3635
(let [handler (-> (constantly (-> (response "foo") (content-type "text/plain")))

0 commit comments

Comments
 (0)