Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontViewer: Rules Issue (test font NotoNaskhArabic-Regular.ttf) #9

Open
paulushub opened this issue Nov 1, 2018 · 1 comment
Open

Comments

@paulushub
Copy link

Currently the font viewer cannot display the Noto NotoNaskhArabic-Regular.ttf because several 10,000 rules are created causing the application to freeze.

If you comment out line 19 or the code children.add(new GsubRuleSetsNode(gsub)); in the following file
com.google.typography.font.tools.fontviewer.GsubTableNode, it will load normally except, there is not rules node.

The actual problem location is applyChainingLookup(...) method in com.google.typography.font.sfntly.table.opentype.component.RuleExtractor where the targetRules becomes very large for some fonts, even though it works with many fonts without a problem.

Any idea what might be the cause of this issue or whether that is expected? (I just started learning about font formats).

@rillig
Copy link
Owner

rillig commented Nov 7, 2018

Off the top of my head, I don't have any idea because I don't know the OpenType font format by heart as well.

A little background: I just inherited this project from Google because I had written the FontViewer, in order to understand a strange bug of Microsoft Office 2010 displaying a wrong Arabic character in Calibri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants