From 717cb2ed3bda5909ec8770d510ae28fe981fa414 Mon Sep 17 00:00:00 2001
From: Brian Holmes <briangregoryholmes@gmail.com>
Date: Fri, 21 Mar 2025 12:29:16 -0400
Subject: [PATCH] fix: use multiline input for advanced dimension expressions

---
 .../src/features/visual-metrics-editing/Sidebar.svelte    | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/web-common/src/features/visual-metrics-editing/Sidebar.svelte b/web-common/src/features/visual-metrics-editing/Sidebar.svelte
index eef55b4cc28..2f7a8e4a9ac 100644
--- a/web-common/src/features/visual-metrics-editing/Sidebar.svelte
+++ b/web-common/src/features/visual-metrics-editing/Sidebar.svelte
@@ -242,6 +242,12 @@
         } else {
           newItem.delete("format_preset");
         }
+      } else if (label === "SQL expression" && type === "dimensions") {
+        if (key === "expression") {
+          newItem.delete("column");
+        } else {
+          newItem.delete("expression");
+        }
       }
 
       if (editingClone[key] || editingClone[key] === false)
@@ -313,7 +319,7 @@
           {optional}
           {fontFamily}
           {placeholder}
-          multiline={key === "description"}
+          multiline={key === "description" || key === "expression"}
           enableSearch={key === "column"}
           {selected}
           bind:value={editingClone[key]}