Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery status-based ON_AC uses faulty logic #115

Closed
luke-jr opened this issue Nov 10, 2017 · 2 comments
Closed

Battery status-based ON_AC uses faulty logic #115

luke-jr opened this issue Nov 10, 2017 · 2 comments

Comments

@luke-jr
Copy link

luke-jr commented Nov 10, 2017

        if [ $FOUND_SYS_CLASS_POWER_SUPPLY_AC != 1 ] && [ $BATTERY_NOT_DISCHARGING = 1 ]; then

But BATTERY_NOT_DISCHARGING can only ever be set if FOUND_SYS_CLASS_POWER_SUPPLY_AC is also being set. Should FOUND_SYS_CLASS_POWER_SUPPLY_AC=1 be moved inside the "Mains" check??

@rickysarraf
Copy link
Owner

This must be the effect of #116

Wherein you don't have a usual power supply subsystem.

@rickysarraf
Copy link
Owner

Closing this issue, for #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants