Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Performance: handler pointers collection on server #179

Open
Samuel-B-D opened this issue Jul 21, 2021 · 1 comment
Open

[FEATURE] Performance: handler pointers collection on server #179

Samuel-B-D opened this issue Jul 21, 2021 · 1 comment
Assignees
@richerarc

Comments

@Samuel-B-D
Copy link
Contributor

Description of the feature
To improve performance, instead of using dynamic dispatch at runtime, in Server::build we could create a fixed list pointers to all registered handlers, which could be iterated through without having to use any dyn_handle.

Is your feature request related to a problem?
Not related to a problem, just a performance improvement
@richerarc
Copy link
Owner

This could be an interesting improvement but it would significantly increase the amount of unsafe blocks in the codebase 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richerarc richerarc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richerarc @Samuel-B-D