Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touch functionality added even though touch:false #76

Open
mdoelker opened this issue Apr 15, 2014 · 1 comment
Open

touch functionality added even though touch:false #76

mdoelker opened this issue Apr 15, 2014 · 1 comment

Comments

@mdoelker
Copy link

When including the touch plugin, the touch functionality is always initialized when the carousel is created even though the touch option is false.

I think the _create method is lacking a check similar to what can be found in the autoscroll plugin:

_create: function () {

    _super._create.apply(this);

    if (!this.options.touch) { // <-- Hey, I'm new here
        return;
    }

    this._initDrag();

    return;
},

This is on v1.0.2. I'm using { touch: Modernizr && Modernizr.touch } like it was stated in the docs.

@richardscarrott
Copy link
Owner

Good spot, feel free to send a pull request and I'll merge it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants