Skip to content

Conversation

@tremes
Copy link
Contributor

@tremes tremes commented Nov 21, 2025

There was an issue with two cluster-monitoring-view clusterrolebindings (one for korrel8r and second one for health analyzer) during the release.

We quickly fixed this during the release by renaming the crb for the health analyzer. This is an attempt to improve the hotfix:

  • have only one function for crb creation
  • crb names are prefixed with the plugin name

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgbernalp
Copy link
Contributor

/lgtm

@anpingli
Copy link

/label qe-approved

@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2025

@anpingli: The label(s) qe-approved cannot be applied, because the repository doesn't have them.

In response to this:

/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@anpingli
Copy link

LGTM

@tremes tremes changed the title WIP fix: fix & rename health-analyzer and korrel8r clusterrolebindings fix: fix & rename health-analyzer and korrel8r clusterrolebindings Nov 25, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 42301f7 into rhobs:main Nov 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants