Skip to content

Commit 4314833

Browse files
authored
fix: reconcile incident related resources only in 4.19+ (#921)
1 parent 6b5034b commit 4314833

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

pkg/controllers/uiplugin/components.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,10 @@ func pluginComponentReconcilers(plugin *uiv1alpha1.UIPlugin, pluginInfo UIPlugin
116116
if plugin.Spec.Type == uiv1alpha1.TypeMonitoring {
117117
monitoringConfig := plugin.Spec.Monitoring
118118
serviceAccountName := plugin.Name + serviceAccountSuffix
119-
incidentsEnabled := monitoringConfig != nil && monitoringConfig.Incidents != nil && monitoringConfig.Incidents.Enabled
119+
incidentsEnabled := monitoringConfig != nil &&
120+
monitoringConfig.Incidents != nil &&
121+
monitoringConfig.Incidents.Enabled &&
122+
pluginInfo.HealthAnalyzerImage != ""
120123
components = append(components,
121124
reconciler.NewOptionalUpdater(newClusterRoleBinding(namespace, serviceAccountName, "cluster-monitoring-view", "cluster-monitoring-view"), plugin, incidentsEnabled),
122125
reconciler.NewOptionalUpdater(newClusterRoleBinding(namespace, serviceAccountName, "system:auth-delegator", serviceAccountName+"-system-auth-delegator"), plugin, incidentsEnabled),

0 commit comments

Comments
 (0)