-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DialogPanel? #112
Comments
+1 for this |
I would be willing to invest time in a PR if there was documentation with pointers on how to port components. I haven't found it. |
My first pass on this seems to do the job, probably not production ready, but would love to make it so in a pr. |
@extremelygooddeveloper Unless there is a misunderstanding but the dialog panel is on the example page here https://svelte-headlessui.goss.io/docs/dialog |
@petr24 Hmm, i only see these |
Yes, there is no DialogPanel on that page. |
Well there is no "DialogPanel" in tailwind css or headless UI, it's called just "Dialog". I think this can be closed out. |
I mis-understood your question, and my answers were wrong. I see you were asking about "Dialog.Panel" with svelte variant being "DialogPanel", however I'm not sure it's necessary. I looked at the DOM for both headless UI example, and svelte headless UI, and it's the same. Parent Div with three children, h3, two divs. So it seems like this package has the function of Dialog.Panel without explicitly copying the headless UI api. |
For reference, if it can be useful these layouts use DialogPanel: https://tailwindui.com/components/application-ui/application-shells/sidebar see Vue Code. I have tried to replace in my code DialogPanel with Dialog. However the visual is not good for the moment. |
@coin-au-carre Yes, that was my experience as well, iirc my first pass on implementing DialogPanel worked for me. |
Thanks @extremelygooddeveloper I will try it :). Maybe you should propose a PR ? |
Bumping that @iv-ar should turn this into a PR! |
I think the main functionality is to trigger a close of the dialog when a click-event is made outside of it. I would echo the requests for @iv-ar to turn this into a PR. Thank you all in advance! |
I'm not really sure what DialogPanel does. I've just replaced them with divs and never noticed anything wrong. |
Are you able to close the dialog by clicking outside of it? |
Ah yes I believe that may be it. I cannot do that by default, however I do not mind creating that functionality manually. |
From the documentation, clicking outside modal/dialog works as expected.
|
Headless ui has Dialog.Panel, I am unable to find it in svelte-headlessui. Is this because it is not implemented here, or am i missing something about the need for Dialog.Panel in this port?
Thanks!
The text was updated successfully, but these errors were encountered: