diff --git a/gui/src/app.rs b/gui/src/app.rs index 7dd8625..bb263a9 100644 --- a/gui/src/app.rs +++ b/gui/src/app.rs @@ -334,7 +334,7 @@ impl eframe::App for TemplateApp { self.plugin_filter = String::new(); } else { // add notes to filter - self.plugin_filter = mod_name.clone(); + self.plugin_filter.clone_from(mod_name); } } }); @@ -435,7 +435,7 @@ impl eframe::App for TemplateApp { frame.frame.fill = bg_color; // update hover filter - self.plugin_hover_filter = w.get_plugins().clone(); + self.plugin_hover_filter.clone_from(&w.get_plugins()); } else { self.plugin_hover_filter = vec![]; } diff --git a/src/parser.rs b/src/parser.rs index fc351c9..952c248 100644 --- a/src/parser.rs +++ b/src/parser.rs @@ -457,9 +457,13 @@ impl Parser { let mut tokens: Vec = vec![]; // ignore everything after ; - let mut line = line.clone(); + let line = line.clone(); if line.contains(';') { - line = line.split(';').next().unwrap_or("").trim().to_owned(); + line.split(';') + .next() + .unwrap_or("") + .trim() + .clone_into(&mut line.to_owned()); } let mut is_quoted = false; diff --git a/src/sorter.rs b/src/sorter.rs index 7ae8b3d..31efd1e 100644 --- a/src/sorter.rs +++ b/src/sorter.rs @@ -135,8 +135,8 @@ impl Sorter { for er in &err { error!("cycles:"); for e in er { - error!("\t{}: {}", e, index_dict_rev[&e]); - res.push(index_dict_rev[&e].clone()); + error!("\t{}: {}", e, index_dict_rev[e]); + res.push(index_dict_rev[e].clone()); } } diff --git a/tests/unit_rules_tests.rs b/tests/unit_rules_tests.rs index 66846dd..54ba3a0 100644 --- a/tests/unit_rules_tests.rs +++ b/tests/unit_rules_tests.rs @@ -235,7 +235,7 @@ mod unit_tests { #[test] fn test_order_case() { { - let mods = vec![ + let mods = [ "a.esp".to_string(), "b.ESP".to_string(), "c.esp".to_string(),