Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in Week 39 olympiad data #754

Closed
emitanaka opened this issue Sep 21, 2024 · 2 comments · Fixed by #755
Closed

Mistake in Week 39 olympiad data #754

emitanaka opened this issue Sep 21, 2024 · 2 comments · Fixed by #755

Comments

@emitanaka
Copy link

I think there's something wrong with the week 39 data @havishak. If you look at individual_results_df, each contestant competes from 1959 to 2024, which is impossible.

library(tidyverse)
tuesdata <- tidytuesdayR::tt_load('2024-09-24')
individual_results_df <- tuesdata$individual_results_df

individual_results_df |> 
  summarise(year_min = min(year), year_max = max(year), .by = contestant)
#> # A tibble: 609 × 3
#>    contestant                     year_min year_max
#>    <chr>                             <dbl>    <dbl>
#>  1 Haojia Shi                         1959     2024
#>  2 Ivan Chasovskikh                   1959     2024
#>  3 Alexander Wang                     1959     2024
#>  4 Satoshi Kano                       1959     2024
#>  5 László Bence Simon                 1959     2024
#>  6 Adhitya Mangudy Venkata Ganesh     1959     2024
#>  7 Qiming Xu                          1959     2024
#>  8 Hyeongjoe Chu                      1959     2024
#>  9 Alex Chui                          1959     2024
#> 10 Jessica Wan                        1959     2024
#> # ℹ 599 more rows

Created on 2024-09-21 with reprex v2.1.0

@jonthegeek
Copy link
Collaborator

Thanks for the catch! I'm looking into it, and hopefully I can get it fixed before we release this one on Monday!

@havishak
Copy link
Contributor

Thanks @emitanaka for catching it, and @jonthegeek for fixing the bug! Learnt about time-outs in webscrapping through this process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants