Rethink default scopes

[nymous]

Not sure about our use of the default_scope in app/models/article.rb, app/models/payment_method.rb, app/models/subscription_offer.rb. It sure is easier to query later, however it also has some unexpected effects as it changes a new Article to set deleted_at: nil by default (though in this case this is the value we expect).
It can also be hard to cancel or override correctly, for example Article.first.refunds.unscoped will remove the WHERE refunds.article_id = $article_id constraint and show you all refunds, Article.first.unscoped.refunds doesn't change anything compared to without unscoped, and the correct thing is Article.unscoped.first.refunds. Also if you do Article.where(name: 'Câble').unscoped, the where clause is removed because unscoped removes everything before it.

For now it doesn't seem to cause any issue for us, so your call.

More reading:

• https://piechowski.io/post/why-is-default-scope-bad-rails/
• https://www.rubyguides.com/2019/10/scopes-in-ruby-on-rails/
• https://andycroll.com/ruby/dont-use-default-scope/
• https://dev.to/lewuathe/why-we-should-avoid-defaultscope-in-rails-3ofo
• https://stackoverflow.com/questions/25087336/why-is-using-the-rails-default-scope-often-recommend-against
• Really interesting, from someone who maintained a gem for soft delete then created another one to fix its shortcomings https://github.com/jhawthorn/discard#why-not-paranoia-or-acts_as_paranoid

(Taken from #467 (comment))