Skip to content

Commit 2e6b919

Browse files
authored
Merge pull request #19 from reviewdog/add_fail_level
Add fail_level and deduplicate fail_on_error
2 parents 1a8ed27 + 8dac698 commit 2e6b919

File tree

4 files changed

+21
-1
lines changed

4 files changed

+21
-1
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
reporter: github-pr-review
4343
level: error
4444
filter_mode: file
45-
fail_on_error: true
45+
fail_level: any
4646
- name: check the exit code
4747
if: ${{ !success() }}
4848
run: echo 'The previous step should fail' && exit 1

README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,19 @@ inputs:
3737
Filtering mode for the reviewdog command [added,diff_context,file,nofilter].
3838
Default is added.
3939
default: 'added'
40+
fail_level:
41+
description: |
42+
If set to `none`, always use exit code 0 for reviewdog.
43+
Otherwise, exit code 1 for reviewdog if it finds at least 1 issue with severity greater than or equal to the given level.
44+
Possible values: [none,any,info,warning,error]
45+
Default is `none`.
46+
default: 'none'
4047
fail_on_error:
4148
description: |
49+
Deprecated, use `fail_level` instead.
4250
Exit code for reviewdog when errors are found [true,false].
4351
Default is `false`.
52+
deprecationMessage: Deprecated, use `fail_level` instead.
4453
default: 'false'
4554
reviewdog_flags:
4655
description: 'Additional reviewdog flags.'

action.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,19 @@ inputs:
2323
Filtering mode for the reviewdog command [added,diff_context,file,nofilter].
2424
Default is added.
2525
default: 'added'
26+
fail_level:
27+
description: |
28+
If set to `none`, always use exit code 0 for reviewdog.
29+
Otherwise, exit code 1 for reviewdog if it finds at least 1 issue with severity greater than or equal to the given level.
30+
Possible values: [none,any,info,warning,error]
31+
Default is `none`.
32+
default: 'none'
2633
fail_on_error:
2734
description: |
35+
Deprecated, use `fail_level` instead.
2836
Exit code for reviewdog when errors are found [true,false].
2937
Default is `false`.
38+
deprecationMessage: Deprecated, use `fail_level` instead.
3039
default: 'false'
3140
reviewdog_flags:
3241
description: 'Additional reviewdog flags.'
@@ -52,6 +61,7 @@ runs:
5261
INPUT_LEVEL: ${{ inputs.level }}
5362
INPUT_REPORTER: ${{ inputs.reporter }}
5463
INPUT_FILTER_MODE: ${{ inputs.filter_mode }}
64+
INPUT_FAIL_LEVEL: ${{ inputs.fail_level }}
5565
INPUT_FAIL_ON_ERROR: ${{ inputs.fail_on_error }}
5666
INPUT_REVIEWDOG_FLAGS: ${{ inputs.reviewdog_flags }}
5767
INPUT_TYPOS_FLAGS: ${{ inputs.typos_flags }}

script.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ typos ${INPUT_TYPOS_FLAGS} --format json |
2525
-name="${INPUT_TOOL_NAME}" \
2626
-reporter="${INPUT_REPORTER}" \
2727
-filter-mode="${INPUT_FILTER_MODE}" \
28+
-fail-level="${INPUT_FAIL_LEVEL}" \
2829
-fail-on-error="${INPUT_FAIL_ON_ERROR}" \
2930
-level="${INPUT_LEVEL}" \
3031
-tee \

0 commit comments

Comments
 (0)