Skip to content

Commit 0e4ab9e

Browse files
authored
Merge pull request #70 from reviewdog/sensible-exclude-default
Add sensible default value for exclude param
2 parents c3f6296 + 4f61ed3 commit 0e4ab9e

File tree

3 files changed

+28
-6
lines changed

3 files changed

+28
-6
lines changed

.github/workflows/test.yml

Lines changed: 26 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ jobs:
1616
file: testdata/testfile
1717
version_name: REVIEWDOG_VERSION
1818
repo: reviewdog/reviewdog
19-
2019
- name: Check diff
2120
run: git diff
2221

@@ -30,7 +29,6 @@ jobs:
3029
file: testdata/testfile
3130
version_name: REDPEN_VERSION
3231
repo: redpen-cc/redpen
33-
3432
- name: Check diff
3533
run: git diff
3634

@@ -44,7 +42,6 @@ jobs:
4442
file: testdata/testfile
4543
version_name: TMUX_VERSION
4644
repo: tmux/tmux
47-
4845
- name: Check diff
4946
run: git diff
5047

@@ -58,7 +55,6 @@ jobs:
5855
file: testdata/testfile
5956
version_name: POETRY_VERSION
6057
repo: python-poetry/poetry
61-
6258
- name: Check diff
6359
run: git diff
6460

@@ -73,7 +69,6 @@ jobs:
7369
version_name: THEMIS_VERSION
7470
repo: thinca/vim-themis
7571
tag: true
76-
7772
- name: Check diff
7873
run: git diff
7974

@@ -88,7 +83,6 @@ jobs:
8883
version_name: TERRAFORM_VERSION
8984
repo: hashicorp/terraform
9085
include: '^\d+\.\d+\.\d+$'
91-
9286
- name: Check diff
9387
run: git diff
9488

@@ -103,6 +97,32 @@ jobs:
10397
version_name: TERRAFORM_VERSION
10498
repo: hashicorp/terraform
10599
exclude: '-(alpha|beta|rc)'
100+
- name: Check diff
101+
run: git diff
106102

103+
exclude-default:
104+
runs-on: ubuntu-latest
105+
steps:
106+
- uses: actions/checkout@v4
107+
- uses: ./
108+
id: depup
109+
with:
110+
file: testdata/testfile
111+
version_name: TERRAFORM_VERSION
112+
repo: hashicorp/terraform
113+
- name: Check diff
114+
run: git diff
115+
116+
exclude-remove:
117+
runs-on: ubuntu-latest
118+
steps:
119+
- uses: actions/checkout@v4
120+
- uses: ./
121+
id: depup
122+
with:
123+
file: testdata/testfile
124+
version_name: TERRAFORM_VERSION
125+
repo: hashicorp/terraform
126+
exclude: '' # empty
107127
- name: Check diff
108128
run: git diff

action.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ inputs:
2323
required: false
2424
exclude:
2525
description: 'Regular expression not to use matched versions.'
26+
default: '\b(rc|alpha|beta)(\b|\d+)'
2627
required: false
2728
outputs:
2829
current:

with-pr/action.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ inputs:
2323
required: false
2424
exclude:
2525
description: 'Regular expression not to use matched versions.'
26+
default: '\b(rc|alpha|beta)(\b|\d+)'
2627
required: false
2728
tag_prefix:
2829
description: 'Tag prefix used for building link in PR description'

0 commit comments

Comments
 (0)