Trying to capture exit code when set -e is active

[dgholz]

I see in the new composite action, we try to capture the exit code from running & reporting the Brakeman findings:

brakeman [...] | reviewdog [...]

exit_code=$?
echo '::endgroup::'

exit $exit_code

action-brakeman/script.sh

Line 49 in 3073c89

exit_code=$?

I think this is so the ::endgroup:: can be printed to close the group, but because we're running with -e, the script will exit as soon as the first command fails.

The way to capture exit codes under set -e is like:

if ! cmd
then
  exit_code=$?
fi
cleanup
exit $exit_code

or using traps

[dgholz]

In my opinion, this isn't a bug and doesn't need a fix. It's just code that doesn't do anything and might confuse or mislead future maintainers into thinking it serves a purpose.