Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Streams instead of file paths #14

Open
4 of 6 tasks
pixeldesu opened this issue May 19, 2019 · 0 comments
Open
4 of 6 tasks

Use Streams instead of file paths #14

pixeldesu opened this issue May 19, 2019 · 0 comments
Labels
good first issue Good for newcomers refactoring Refactor related issues

Comments

@pixeldesu
Copy link
Member

pixeldesu commented May 19, 2019 •
edited
Loading

This is a refactoring issue related to basically all my implementations of PangLib libraries.

Instead of passing a filePath to the constructor of a *File class, pass a Stream to it instead. These can be used by the BinaryReader just fine.

Please open seperate Pull Requests for each library you are refactoring!

To-Do List:

  • PangLib.DAT
  • PangLib.IFF
  • PangLib.PAK
  • PangLib.PET
  • PangLib.UCC
  • PangLib.UpdateList
@pixeldesu pixeldesu added good first issue Good for newcomers refactoring Refactor related issues labels May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactoring Refactor related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixeldesu