Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some playlists fail to display correct album art for certain tracks #189

Open
peterklingelhofer opened this issue Mar 1, 2022 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@peterklingelhofer
Copy link
Member

Operating system

macOS 11.6.2

Browser name and version

Firefox 97.0.1

Expected behavior

Some playlists should show proper album art for each track.

Actual behavior

Some playlists do not show proper album art for each track and merely duplicate one of the earlier track's album art.

Steps to reproduce behavior

View the Resonate March 27, 2022 Camp Radio Playlist
Screen Shot 2022-02-28 at 7 37 44 PM

@peterklingelhofer peterklingelhofer added bug Something isn't working help wanted Extra attention is needed labels Mar 1, 2022
@peterklingelhofer peterklingelhofer added the good first issue Good for newcomers label Apr 8, 2022
@simonv3
Copy link

simonv3 commented Apr 11, 2022

Looking at the API response that populates this particular playlist:

GET https://beta.stream.resonate.coop/api/v2/trackgroups/6a2ec571-3887-4ad5-9048-70d360ce1731

It looks like the covers for all these songs actually are all the same (except for the second one). I dunno if that's a bug with the API then, maybe from when the songs were added to the playlist?

@peterklingelhofer
Copy link
Member Author

Hmmm... That means it could either be a problem with the addToPlaylistAction on L506 in packages/menu-button-options-component/index.js in this repository, or a bug in our tracks-api repository, which is not yet open source. If it's on this side, I think we need to check and see if data.cover on L546 is always correct. When a track gets the wrong album art, in my experience, it's always been the album art from a different track already on the playlist from what I've seen. If we can't find a time where data.cover is wrong, then we'll know for sure it's in the code in tracks-api that contains the bug.

@peterklingelhofer peterklingelhofer removed the good first issue Good for newcomers label Apr 24, 2022
@caprenter
Copy link
Contributor

Here are a couple of more examples of playlists where this happens. the example at the start of this thread was also from me.
All playlists were made using Firefox on Ubuntu.
https://stream.resonate.coop/u/18562/playlist/radio-show
https://stream.resonate.coop/u/18562/playlist/2022-04-24-resonate-on-camp-radio

@caprenter
Copy link
Contributor

I think I've worked out where this behaviour occurs.

If I add a track to the playlist from the 'playing widget' it gets the correct artwork - where it seems to use the 'playlist artwork' is when a track is added from a release page track list, or directly from an artist page i.e. not in the 'now playing widget'

Hope that makes sense. I'm not familiar enough with the code yet to check it.

@caprenter
Copy link
Contributor

When a track gets the wrong album art, in my experience, it's always been the album art from a different track already on the playlist from what I've seen.

I think that the duplicate cover art is always the artwork from the first track in the playlist - which is also the artwork given to the playlist itself when it is first created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants