Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all links to resonate.is and resonate.coop to use the SITE_DOMAIN env variable #166

Open
jackhajb opened this issue Feb 13, 2022 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@jackhajb
Copy link

jackhajb commented Feb 13, 2022

Tasks

  1. Update all links that reference resonate.is and resonate.coop to use the SITE_DOMAIN env variable.
  2. Create a fallback for the SITE_DOMAIN variable that will use resonate.coop
  3. Double check all updated routes for the links using the SITE_DOMAIN work properly on the new site. The new site can be tested at resonate.space. e.g. https://resonate.coop/the-coop is broken if you go to route on resonate.space, https://resonate.space/the-coop, it instead needs to be updated to ``https://resonate.space/coop` .

Do not modify any community.resonate.is links

@whatSocks
Copy link
Contributor

some items seem to only exist on resonate.is

/stream/beta/assets/manifest.json
for example: https://static.resonate.coop/pwa_assets/icon-128x128.png

images from the albums:
https://upload.resonate.is/images/046cb430-1680-4dc4-a5c2-7378eb250ae2-x120.jpg
does not exist at
https://upload.resonate.coop/images/046cb430-1680-4dc4-a5c2-7378eb250ae2-x120.jpg

https://resonate.coop/join redirects to https://resonate.is/join

Maybe this could be split into updating API stuff and updating non-API stuff?

@jackhajb jackhajb added bug Something isn't working help wanted Extra attention is needed and removed bug Something isn't working labels Feb 13, 2022
@mcfiredrill
Copy link
Contributor

I found the APP_HOST env var in this repo, which seems to be doing the same thing. Could we use that ?

APP_HOST=https://beta.stream.resonate.coop

@jackhajb
Copy link
Author

@whatSocks @mcfiredrill Sorry for the confusion here, the goal is to update the site links.
The APP_HOST variable is for the streaming player which is different from the website.

Let me know if that adds clarity

@mcfiredrill
Copy link
Contributor

mcfiredrill commented Feb 23, 2022

@whatSocks @mcfiredrill Sorry for the confusion here, the goal is to update the site links.
The APP_HOST variable is for the streaming player which is different from the website.

@jackhajb
Ah right, for the new website correct?
https://github.com/resonatecoop/website

@MLK97
Copy link

MLK97 commented Mar 7, 2022

Hello,
trying to help with this.
I am currently looking at the components/footer/index.js-file.
Am I understanding it correctly that for instance in this file you want to edit the link to the About Section from

${link({ prefix: 'link mid-gray pa0 lh-copy', 
             text: 'About', 
             href: 'https://resonate.coop/about', 
             target: '_blank' 
})}

to something like

${link({ prefix: 'link mid-gray pa0 lh-copy', 
             text: 'About', 
             href: process.env.SITE_DOMAIN+'/about', 
             target: '_blank' 
})}

@caprenter
Copy link
Contributor

This solution is for the streaming site (this repo) and would currently give us the link: resonate.localhost/about (with SITE_DOMAIN defined in the /base/.env file) WITHOUT "https://"

So I think it's a good solution as long as we can put https:// in the SITE_Domain variable in .env - is that acceptable?

${link({ prefix: 'link mid-gray pa0 lh-copy', 
             text: 'About', 
             href: process.env.SITE_DOMAIN+'/about', 
             target: '_blank' 
})}

@peterklingelhofer
Copy link
Member

Hey @caprenter, yes, I think that would be acceptable (apologies for the delayed response).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
No open projects
Development

No branches or pull requests

6 participants