-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all links to resonate.is and resonate.coop to use the SITE_DOMAIN env variable #166
Comments
some items seem to only exist on resonate.is /stream/beta/assets/manifest.json images from the albums: https://resonate.coop/join redirects to https://resonate.is/join Maybe this could be split into updating API stuff and updating non-API stuff? |
I found the APP_HOST env var in this repo, which seems to be doing the same thing. Could we use that ? Line 3 in f314a36
|
@whatSocks @mcfiredrill Sorry for the confusion here, the goal is to update the site links. Let me know if that adds clarity |
@jackhajb |
Hello, ${link({ prefix: 'link mid-gray pa0 lh-copy',
text: 'About',
href: 'https://resonate.coop/about',
target: '_blank'
})} to something like ${link({ prefix: 'link mid-gray pa0 lh-copy',
text: 'About',
href: process.env.SITE_DOMAIN+'/about',
target: '_blank'
})} |
This solution is for the streaming site (this repo) and would currently give us the link: resonate.localhost/about (with SITE_DOMAIN defined in the /base/.env file) WITHOUT "https://" So I think it's a good solution as long as we can put https:// in the SITE_Domain variable in .env - is that acceptable?
|
Hey @caprenter, yes, I think that would be acceptable (apologies for the delayed response). |
Tasks
resonate.is
andresonate.coop
to use theSITE_DOMAIN
env variable.SITE_DOMAIN
variable that will useresonate.coop
SITE_DOMAIN
work properly on the new site. The new site can be tested atresonate.space
. e.g. https://resonate.coop/the-coop is broken if you go to route onresonate.space
, https://resonate.space/the-coop, it instead needs to be updated to ``https://resonate.space/coop` .Do not modify any
community.resonate.is
linksThe text was updated successfully, but these errors were encountered: